-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrades UniFi Network Application to 9.0.114 #550
Conversation
WalkthroughThis pull request updates the Dockerfile in the UniFi directory. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
unifi/Dockerfile (1)
19-21
: Optional: Consider Package Integrity Verification
For improved security, consider adding a checksum or GPG signature verification step after downloading the package. This can help ensure that the package has not been tampered with before installation. For example:- && curl -J -L -o /tmp/unifi.deb \ - "https://dl.ui.com/unifi/9.0.114/unifi_sysvinit_all.deb" \ + && curl -J -L -o /tmp/unifi.deb \ + "https://dl.ui.com/unifi/9.0.114/unifi_sysvinit_all.deb" \ + && echo "<expected-checksum> /tmp/unifi.deb" | sha256sum --check \If a checksum is provided by the vendor, integrating this check can prevent accidental adoption of a corrupted or malicious package.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
unifi/Dockerfile
(1 hunks)
🔇 Additional comments (1)
unifi/Dockerfile (1)
19-21
: Update UniFi Version in Download URL
The upgrade to version 9.0.114 is correctly reflected in thecurl
command. Please verify that the URL
https://dl.ui.com/unifi/9.0.114/unifi_sysvinit_all.deb
resolves to the intended package and that the new version has been tested with your overall deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cwmoriarty 👍
../Frenck
Release notes: https://community.ui.com/releases/UniFi-Network-Application-9-0-114/35b6e9ac-f63d-46c9-bbbe-74a4a61ac95f
Summary by CodeRabbit